Diff Review

File diffs, rationale, evidence, tests and approve/reject.

P0SOC 2Up to 70% savings

Explorer

src

components

routes

dashboard.tsx+42−8

services

api.ts+18−3

tests

user.service.test.ts+240

.env.example

package.json

README.md

dashboard.tsx+42−8

api.ts+18−3

user.service.test.ts+240

src/routes/dashboard.tsx3 files changed +84 −11

@@ -18,11 +18,16 @@ export default function Dashboard() {

18 useEffect(() => {

19- loadMetrics();

20- if (!loading) {

21- setReady(true);

22- }

23- });

19+ let cancelled = false;

20+ loadMetrics().then(() => {

21+ if (!cancelled) setReady(true);

22+ });

23+ return () => { cancelled = true; };

24+ }, []);

25

@@ -34,7 +39,8 @@ export default function Dashboard() {

39 const rows = metrics.map(toRow);

40- return <MetricGrid rows={rows} />;

40+ const memoRows = useMemo(() => rows, [rows]);

41+ return <MetricGrid rows={memoRows} />;

Rationale

The metrics effect ran on every render and raced unmounts, causing duplicate provider calls and a stale-state warning. The run scopes the effect to mount, cancels in-flight work on cleanup, and memoizes derived rows so the grid stops re-rendering on each poll tick.

Evidence

Tracerun-9 spans 12/12 clean, no retries

Benchmarkdashboard p95 218ms → 141ms

Previewstaging deploy healthy, 8/8 checks

P0 policy · 2 approvals required1 of 2 approvals recorded

Diff Review

File diffs, rationale, evidence, tests and approve/reject.

P0SOC 2Up to 70% savings

Explorer

src

components

routes

dashboard.tsx+42−8

services

api.ts+18−3

tests

user.service.test.ts+240

.env.example

package.json

README.md

dashboard.tsx+42−8

api.ts+18−3

user.service.test.ts+240

src/routes/dashboard.tsx3 files changed +84 −11

@@ -18,11 +18,16 @@ export default function Dashboard() {

18 useEffect(() => {

19- loadMetrics();

20- if (!loading) {

21- setReady(true);

22- }

23- });

19+ let cancelled = false;

20+ loadMetrics().then(() => {

21+ if (!cancelled) setReady(true);

22+ });

23+ return () => { cancelled = true; };

24+ }, []);

25

@@ -34,7 +39,8 @@ export default function Dashboard() {

39 const rows = metrics.map(toRow);

40- return <MetricGrid rows={rows} />;

40+ const memoRows = useMemo(() => rows, [rows]);

41+ return <MetricGrid rows={memoRows} />;

Rationale

The metrics effect ran on every render and raced unmounts, causing duplicate provider calls and a stale-state warning. The run scopes the effect to mount, cancels in-flight work on cleanup, and memoizes derived rows so the grid stops re-rendering on each poll tick.

Evidence

Tracerun-9 spans 12/12 clean, no retries

Benchmarkdashboard p95 218ms → 141ms

Previewstaging deploy healthy, 8/8 checks

P0 policy · 2 approvals required1 of 2 approvals recorded